-
-
Notifications
You must be signed in to change notification settings - Fork 9
Add tests for numpy logsumexp #238
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #238 +/- ##
=======================================
Coverage 84.71% 84.71%
=======================================
Files 41 41
Lines 4945 4945
=======================================
Hits 4189 4189
Misses 756 756 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Happy to expand and modify these tests if we're not capturing something crucial in the comparison against Scipy.
Documentation build overview
Show files changed (12 files in total): 📝 12 modified | ➕ 0 added | ➖ 0 deleted
|
Co-authored-by: Osvaldo A Martin <[email protected]>
Adds more tests for numpy
logsumexp. This seems to be very well in-line with the scipy version.Resolves #223